Repository navigation
test: make UI tests pass on iPad and after the launch test - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
main, 16 UI tests fail on an iPad (A16) simulator running iOS 27. From iPadOS 18 the main tabs sit at the top as plain buttons rather than in a tab bar, soapp.tabBars.buttons["Keys"]finds nothing. The Settings sheet still has a bottom tab bar.NormalUITestsLaunchTestsruns in every screen configuration and leaves the simulator in landscape. In a full run, 3UnblockDurationsUITeststhat run after it fail.Fix
app.mainTab(_:)finds a main tab by its label on iPadOS 18+ iPads and usestabBars.buttonseverywhere else, as before. Every main-tab tap uses it; the Settings tabs are unchanged.setUpWithError. The launch test is unchanged.No app code changes.
Tests
NormalUITests+RecoveryUITestsNormalUITests+RecoveryUITestsCI runs only the unit tests, so the UI results above are from local runs.